loki: Require X-Grafana-User HTTP header
I discovered today that if anonymous Grafana users have Viewer permission, they can use the Datasource API to make arbitrary queries to any backend, even if they cannot access the Explore page directly. This is documented ([issue #48313][0]) as expected behavior. I don't really mind giving anonymous access to the Victoria Metrics datasource, but I definitely don't want anonymous users to be able to make Loki queries and view log data. Since Grafana Datasource Permissions is limited to Grafana Enterprise and not available in the open source version of Grafana, the official recommendation from upstream is to use a separate Organization for the Loki datasource. Unfortunately, this would preclude having dashboards that have graphs from both data sources. Although I don't have any of those right now, I like the idea and may build some eventually. Fortunately, I discovered the `send_user_header` Grafana configuration option. With this enabled, Grafana will send an `X-Grafana-User` header with the username of the user on whose behalf it is making a request to the backend. If the user is not logged in, it does not send the header. Thus, we can detect the presence of this header on the backend and refuse to serve query requests if it is missing. [0]: https://github.com/grafana/grafana/issues/48313master
parent
cdd6a62b5d
commit
01d8f7043b
|
@ -8,6 +8,9 @@ loki.pyrocufflink.blue {
|
||||||
@anonymous {
|
@anonymous {
|
||||||
expression {tls_client_subject} == null
|
expression {tls_client_subject} == null
|
||||||
}
|
}
|
||||||
|
@grafana {
|
||||||
|
header X-Grafana-User *
|
||||||
|
}
|
||||||
handle @anonymous {
|
handle @anonymous {
|
||||||
route /loki/api/v1/push {
|
route /loki/api/v1/push {
|
||||||
reverse_proxy 127.0.0.1:3100
|
reverse_proxy 127.0.0.1:3100
|
||||||
|
@ -20,7 +23,7 @@ loki.pyrocufflink.blue {
|
||||||
}
|
}
|
||||||
respond 403
|
respond 403
|
||||||
}
|
}
|
||||||
handle {
|
handle @grafana {
|
||||||
reverse_proxy 127.0.0.1:3100
|
reverse_proxy 127.0.0.1:3100
|
||||||
}
|
}
|
||||||
tls loki@pyrocufflink.blue {
|
tls loki@pyrocufflink.blue {
|
||||||
|
|
Loading…
Reference in New Issue