From 19a8dc14c8ab0b2adbd802d0f079bc281c65dc15 Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Thu, 26 Jun 2014 16:58:48 +0200 Subject: [PATCH] Fixing milestone serializer, adding duplicated name validation --- taiga/projects/milestones/serializers.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/taiga/projects/milestones/serializers.py b/taiga/projects/milestones/serializers.py index b5f5e188..0a824cfd 100644 --- a/taiga/projects/milestones/serializers.py +++ b/taiga/projects/milestones/serializers.py @@ -25,10 +25,10 @@ from . import models class MilestoneSerializer(serializers.ModelSerializer): user_stories = UserStorySerializer(many=True, required=False) - total_points = serializers.SerializerMethodField('get_total_points') - closed_points = serializers.SerializerMethodField('get_closed_points') - client_increment_points = serializers.SerializerMethodField('get_client_increment_points') - team_increment_points = serializers.SerializerMethodField('get_team_increment_points') + total_points = serializers.SerializerMethodField("get_total_points") + closed_points = serializers.SerializerMethodField("get_closed_points") + client_increment_points = serializers.SerializerMethodField("get_client_increment_points") + team_increment_points = serializers.SerializerMethodField("get_team_increment_points") class Meta: model = models.Milestone @@ -44,3 +44,13 @@ class MilestoneSerializer(serializers.ModelSerializer): def get_team_increment_points(self, obj): return sum(obj.team_increment_points.values()) + + def validate_name(self, attrs, source): + """ + Check the milestone name is not duplicated in the project + """ + qs = models.Milestone.objects.filter(project=attrs["project"], name=attrs[source]) + if qs.exists(): + raise serializers.ValidationError("Name duplicated for the project") + + return attrs