From 376579076a68f4db030cdfc6f0f2917da12fe43c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?= Date: Wed, 13 Nov 2013 12:51:49 +0100 Subject: [PATCH] Now the platform doesn't send emails if there is no changes in the updated fields --- greenmine/base/notifications/models.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/greenmine/base/notifications/models.py b/greenmine/base/notifications/models.py index 9e8f1dea..435271c3 100644 --- a/greenmine/base/notifications/models.py +++ b/greenmine/base/notifications/models.py @@ -78,11 +78,13 @@ class WatchedMixin(models.Model): else: changed_data = data_dict - field_list = [] + fields_list = [] for field_name, data_value in changed_data.items(): - field_list.append(self._get_changed_field(field_name, data_value)) + field_dict = self._get_changed_field(field_name, data_value) + if field_dict["old_value"] != field_dict["new_value"]: + fields_list.append(field_dict) - return sorted(field_list, key=_key_by_notifiable_field) + return sorted(fields_list, key=_key_by_notifiable_field) def get_watchers_to_notify(self, changer): watchers_to_notify = set()