From 4becf63ce4cbcdd8cdb6ddd74060abe26dd3afbb Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Wed, 17 Jul 2013 14:00:04 +0200 Subject: [PATCH] Fixing US permissions --- greenmine/scrum/permissions.py | 4 ++-- greenmine/scrum/serializers.py | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/greenmine/scrum/permissions.py b/greenmine/scrum/permissions.py index 2914e56f..a1a0ebd8 100644 --- a/greenmine/scrum/permissions.py +++ b/greenmine/scrum/permissions.py @@ -23,8 +23,8 @@ class MilestoneDetailPermission(BaseDetailPermission): class UserStoryDetailPermission(BaseDetailPermission): get_permission = "can_view_userstory" - put_permission = "can_change_userstory" - patch_permission = "can_change_userstory" + put_permission = "change_userstory" + patch_permission = "change_userstory" delete_permission = "can_delete_userstory" safe_methods = ['HEAD', 'OPTIONS'] path_to_project = ['project'] diff --git a/greenmine/scrum/serializers.py b/greenmine/scrum/serializers.py index c286bb55..ca00397f 100644 --- a/greenmine/scrum/serializers.py +++ b/greenmine/scrum/serializers.py @@ -54,13 +54,14 @@ class UserStorySerializer(serializers.ModelSerializer): depth = 0 def save_object(self, obj, **kwargs): - role_points = obj._related_data.pop('role_points') + role_points = obj._related_data.pop('role_points', None) super(UserStorySerializer, self).save_object(obj, **kwargs) - for role_id, points_order in role_points.items(): - role_points = obj.role_points.get(role__id=role_id) - role_points.points.order = points_order - role_points.points.save() + if role_points: + for role_id, points_order in role_points.items(): + role_points = obj.role_points.get(role__id=role_id) + role_points.points.order = points_order + role_points.points.save() class MilestoneSerializer(serializers.ModelSerializer):