Updating tests and adding new ones for timeline

tests/integration/test_history.py

@@ -225,7 +225,9 @@ def test_delete_comment_by_project_owner(client):
     key = make_key_from_model_object(us)
     history_entry = f.HistoryEntryFactory.create(type=HistoryType.change,
                                                  comment="testing",
-                                                 key=key)
+                                                 key=key,
+                                                 diff={},
+                                                 user={"pk": project.owner.id})
 
     client.login(project.owner)
     url = reverse("userstory-history-delete-comment", args=(us.id,))

tests/integration/test_notifications.py

@@ -208,7 +208,7 @@ def test_send_notifications_using_services_method(settings, mail):
 
     # Issues
     issue = f.IssueFactory.create(project=project, owner=member2.user)
-    take_snapshot(issue)
+    take_snapshot(issue, user=issue.owner)
     services.send_notifications(issue,
                                 history=history_create)
 
@@ -220,7 +220,7 @@ def test_send_notifications_using_services_method(settings, mail):
 
     # Userstories
     us = f.UserStoryFactory.create(project=project, owner=member2.user)
-    take_snapshot(us)
+    take_snapshot(us, user=us.owner)
     services.send_notifications(us,
                                 history=history_create)
 
@@ -232,7 +232,7 @@ def test_send_notifications_using_services_method(settings, mail):
 
     # Tasks
     task = f.TaskFactory.create(project=project, owner=member2.user)
-    take_snapshot(task)
+    take_snapshot(task, user=task.owner)
     services.send_notifications(task,
                                 history=history_create)
 
@@ -244,7 +244,7 @@ def test_send_notifications_using_services_method(settings, mail):
 
     # Wiki pages
     wiki = f.WikiPageFactory.create(project=project, owner=member2.user)
-    take_snapshot(wiki)
+    take_snapshot(wiki, user=wiki.owner)
     services.send_notifications(wiki,
                                 history=history_create)
 

tests/integration/test_timeline.py

@@ -19,6 +19,7 @@ import pytest
 
 from .. import factories
 
+from taiga.projects.history import services as history_services
 from taiga.timeline import service
 from taiga.timeline.models import Timeline
 
@@ -29,14 +30,14 @@ pytestmark = pytest.mark.django_db
 def test_add_to_object_timeline():
     Timeline.objects.all().delete()
     user1 = factories.UserFactory()
-    user2 = factories.UserFactory()
+    task = factories.TaskFactory()
 
-    service.register_timeline_implementation("users.user", "test", lambda x, extra_data=None: str(id(x)))
+    service.register_timeline_implementation("tasks.task", "test", lambda x, extra_data=None: str(id(x)))
 
-    service._add_to_object_timeline(user1, user2, "test")
+    service._add_to_object_timeline(user1, task, "test")
 
     assert Timeline.objects.filter(object_id=user1.id).count() == 1
-    assert Timeline.objects.order_by("-id")[0].data == id(user2)
+    assert Timeline.objects.order_by("-id")[0].data == id(task)
 
 
 def test_get_timeline():
@@ -45,17 +46,362 @@ def test_get_timeline():
     user1 = factories.UserFactory()
     user2 = factories.UserFactory()
     user3 = factories.UserFactory()
-    user4 = factories.UserFactory()
+    task1= factories.TaskFactory()
+    task2= factories.TaskFactory()
+    task3= factories.TaskFactory()
+    task4= factories.TaskFactory()
 
-    service.register_timeline_implementation("users.user", "test", lambda x, extra_data=None: str(id(x)))
+    service.register_timeline_implementation("tasks.task", "test", lambda x, extra_data=None: str(id(x)))
 
-    service._add_to_object_timeline(user1, user1, "test")
+    service._add_to_object_timeline(user1, task1, "test")
-    service._add_to_object_timeline(user1, user2, "test")
+    service._add_to_object_timeline(user1, task2, "test")
-    service._add_to_object_timeline(user1, user3, "test")
+    service._add_to_object_timeline(user1, task3, "test")
-    service._add_to_object_timeline(user1, user4, "test")
+    service._add_to_object_timeline(user1, task4, "test")
+    service._add_to_object_timeline(user2, task1, "test")
 
-    service._add_to_object_timeline(user2, user1, "test")
+    assert Timeline.objects.filter(object_id=user1.id).count() == 4
+    assert Timeline.objects.filter(object_id=user2.id).count() == 1
+    assert Timeline.objects.filter(object_id=user3.id).count() == 0
 
-    assert service.get_timeline(user1).count() == 4
+
-    assert service.get_timeline(user2).count() == 1
+def test_filter_timeline_no_privileges():
-    assert service.get_timeline(user3).count() == 0
+    Timeline.objects.all().delete()
+    user1 = factories.UserFactory()
+    user2 = factories.UserFactory()
+    task1= factories.TaskFactory()
+
+    service.register_timeline_implementation("tasks.task", "test", lambda x, extra_data=None: str(id(x)))
+    service._add_to_object_timeline(user1, task1, "test")
+    timeline = Timeline.objects.all()
+    timeline = service.filter_timeline_for_user(timeline, user2)
+    assert timeline.count() == 0
+
+
+def test_filter_timeline_public_project():
+    Timeline.objects.all().delete()
+    user1 = factories.UserFactory()
+    user2 = factories.UserFactory()
+    project = factories.ProjectFactory.create(is_private=False)
+    task1= factories.TaskFactory()
+    task2= factories.TaskFactory.create(project=project)
+
+    service.register_timeline_implementation("tasks.task", "test", lambda x, extra_data=None: str(id(x)))
+    service._add_to_object_timeline(user1, task1, "test")
+    service._add_to_object_timeline(user1, task2, "test")
+    timeline = Timeline.objects.all()
+    timeline = service.filter_timeline_for_user(timeline, user2)
+    assert timeline.count() == 1
+
+
+def test_filter_timeline_private_project_anon_permissions():
+    Timeline.objects.all().delete()
+    user1 = factories.UserFactory()
+    user2 = factories.UserFactory()
+    project = factories.ProjectFactory.create(is_private=True, anon_permissions= ["view_tasks"])
+    task1= factories.TaskFactory()
+    task2= factories.TaskFactory.create(project=project)
+
+    service.register_timeline_implementation("tasks.task", "test", lambda x, extra_data=None: str(id(x)))
+    service._add_to_object_timeline(user1, task1, "test")
+    service._add_to_object_timeline(user1, task2, "test")
+    timeline = Timeline.objects.all()
+    timeline = service.filter_timeline_for_user(timeline, user2)
+    assert timeline.count() == 1
+
+
+def test_filter_timeline_private_project_member_permissions():
+    Timeline.objects.all().delete()
+    user1 = factories.UserFactory()
+    user2 = factories.UserFactory()
+    project = factories.ProjectFactory.create(is_private=True)
+    membership = factories.MembershipFactory.create(user=user2, project=project)
+    membership.role.permissions = ["view_tasks"]
+    membership.role.save()
+    task1= factories.TaskFactory()
+    task2= factories.TaskFactory.create(project=project)
+
+    service.register_timeline_implementation("tasks.task", "test", lambda x, extra_data=None: str(id(x)))
+    service._add_to_object_timeline(user1, task1, "test")
+    service._add_to_object_timeline(user1, task2, "test")
+    timeline = Timeline.objects.all()
+    timeline = service.filter_timeline_for_user(timeline, user2)
+    assert timeline.count() == 1
+
+
+def test_create_project_timeline():
+    project = factories.ProjectFactory.create(name="test project timeline")
+    history_services.take_snapshot(project, user=project.owner)
+    project_timeline = service.get_project_timeline(project)
+    assert project_timeline[0].event_type == "projects.project.create"
+    assert project_timeline[0].data["project"]["name"] == "test project timeline"
+    assert project_timeline[0].data["user"]["pk"] == project.owner.id
+    assert project_timeline[0].data["user"]["name"] == project.owner.get_full_name()
+
+
+def test_create_milestone_timeline():
+    milestone = factories.MilestoneFactory.create(name="test milestone timeline")
+    history_services.take_snapshot(milestone, user=milestone.owner)
+    milestone_timeline = service.get_project_timeline(milestone.project)
+    assert milestone_timeline[0].event_type == "milestones.milestone.create"
+    assert milestone_timeline[0].data["milestone"]["name"] == "test milestone timeline"
+    assert milestone_timeline[0].data["user"]["pk"] == milestone.owner.id
+    assert milestone_timeline[0].data["user"]["name"] == milestone.owner.get_full_name()
+
+
+def test_create_user_story_timeline():
+    user_story = factories.UserStoryFactory.create(subject="test us timeline")
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    project_timeline = service.get_project_timeline(user_story.project)
+    assert project_timeline[0].event_type == "userstories.userstory.create"
+    assert project_timeline[0].data["userstory"]["subject"] == "test us timeline"
+    assert project_timeline[0].data["user"]["pk"] == user_story.owner.id
+    assert project_timeline[0].data["user"]["name"] == user_story.owner.get_full_name()
+
+
+def test_create_issue_timeline():
+    issue = factories.IssueFactory.create(subject="test issue timeline")
+    history_services.take_snapshot(issue, user=issue.owner)
+    project_timeline = service.get_project_timeline(issue.project)
+    assert project_timeline[0].event_type == "issues.issue.create"
+    assert project_timeline[0].data["issue"]["subject"] == "test issue timeline"
+    assert project_timeline[0].data["user"]["pk"] == issue.owner.id
+    assert project_timeline[0].data["user"]["name"] == issue.owner.get_full_name()
+
+
+def test_create_task_timeline():
+    task = factories.TaskFactory.create(subject="test task timeline")
+    history_services.take_snapshot(task, user=task.owner)
+    project_timeline = service.get_project_timeline(task.project)
+    assert project_timeline[0].event_type == "tasks.task.create"
+    assert project_timeline[0].data["task"]["subject"] == "test task timeline"
+    assert project_timeline[0].data["user"]["pk"] == task.owner.id
+    assert project_timeline[0].data["user"]["name"] == task.owner.get_full_name()
+
+
+def test_create_wiki_page_timeline():
+    page = factories.WikiPageFactory.create(slug="test wiki page timeline")
+    history_services.take_snapshot(page, user=page.owner)
+    project_timeline = service.get_project_timeline(page.project)
+    assert project_timeline[0].event_type == "wiki.wikipage.create"
+    assert project_timeline[0].data["wiki_page"]["slug"] == "test wiki page timeline"
+    assert project_timeline[0].data["user"]["pk"] == page.owner.id
+    assert project_timeline[0].data["user"]["name"] == page.owner.get_full_name()
+
+
+def test_create_membership_timeline():
+    membership = factories.MembershipFactory.create()
+    project_timeline = service.get_project_timeline(membership.project)
+    user_timeline = service.get_user_timeline(membership.user)
+    assert project_timeline[0].event_type == "projects.membership.create"
+    assert project_timeline[0].data["project"]["id"] == membership.project.id
+    assert project_timeline[0].data["user"]["id"] == membership.user.id
+    assert project_timeline[0].data["user"]["name"] == membership.user.get_full_name()
+    assert user_timeline[0].event_type == "projects.membership.create"
+    assert user_timeline[0].data["project"]["id"] == membership.project.id
+    assert user_timeline[0].data["user"]["id"] == membership.user.id
+    assert user_timeline[0].data["user"]["name"] == membership.user.get_full_name()
+
+
+def test_update_project_timeline():
+    project = factories.ProjectFactory.create(name="test project timeline")
+    history_services.take_snapshot(project, user=project.owner)
+    project.name = "test project timeline updated"
+    project.save()
+    history_services.take_snapshot(project, user=project.owner)
+    project_timeline = service.get_project_timeline(project)
+    assert project_timeline[0].event_type == "projects.project.change"
+    assert project_timeline[0].data["project"]["name"] == "test project timeline updated"
+    assert project_timeline[0].data["values_diff"]["name"][0] == "test project timeline"
+    assert project_timeline[0].data["values_diff"]["name"][1] == "test project timeline updated"
+
+
+def test_update_milestone_timeline():
+    milestone = factories.MilestoneFactory.create(name="test milestone timeline")
+    history_services.take_snapshot(milestone, user=milestone.owner)
+    milestone.name = "test milestone timeline updated"
+    milestone.save()
+    history_services.take_snapshot(milestone, user=milestone.owner)
+    project_timeline = service.get_project_timeline(milestone.project)
+    assert project_timeline[0].event_type == "milestones.milestone.change"
+    assert project_timeline[0].data["milestone"]["name"] == "test milestone timeline updated"
+    assert project_timeline[0].data["values_diff"]["name"][0] == "test milestone timeline"
+    assert project_timeline[0].data["values_diff"]["name"][1] == "test milestone timeline updated"
+
+
+def test_update_user_story_timeline():
+    user_story = factories.UserStoryFactory.create(subject="test us timeline")
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    user_story.subject = "test us timeline updated"
+    user_story.save()
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    project_timeline = service.get_project_timeline(user_story.project)
+    assert project_timeline[0].event_type == "userstories.userstory.change"
+    assert project_timeline[0].data["userstory"]["subject"] == "test us timeline updated"
+    assert project_timeline[0].data["values_diff"]["subject"][0] == "test us timeline"
+    assert project_timeline[0].data["values_diff"]["subject"][1] == "test us timeline updated"
+
+
+def test_update_issue_timeline():
+    issue = factories.IssueFactory.create(subject="test issue timeline")
+    history_services.take_snapshot(issue, user=issue.owner)
+    issue.subject = "test issue timeline updated"
+    issue.save()
+    history_services.take_snapshot(issue, user=issue.owner)
+    project_timeline = service.get_project_timeline(issue.project)
+    assert project_timeline[0].event_type == "issues.issue.change"
+    assert project_timeline[0].data["issue"]["subject"] == "test issue timeline updated"
+    assert project_timeline[0].data["values_diff"]["subject"][0] == "test issue timeline"
+    assert project_timeline[0].data["values_diff"]["subject"][1] == "test issue timeline updated"
+
+
+def test_update_task_timeline():
+    task = factories.TaskFactory.create(subject="test task timeline")
+    history_services.take_snapshot(task, user=task.owner)
+    task.subject = "test task timeline updated"
+    task.save()
+    history_services.take_snapshot(task, user=task.owner)
+    project_timeline = service.get_project_timeline(task.project)
+    assert project_timeline[0].event_type == "tasks.task.change"
+    assert project_timeline[0].data["task"]["subject"] == "test task timeline updated"
+    assert project_timeline[0].data["values_diff"]["subject"][0] == "test task timeline"
+    assert project_timeline[0].data["values_diff"]["subject"][1] == "test task timeline updated"
+
+
+def test_update_wiki_page_timeline():
+    page = factories.WikiPageFactory.create(slug="test wiki page timeline")
+    history_services.take_snapshot(page, user=page.owner)
+    page.slug = "test wiki page timeline updated"
+    page.save()
+    history_services.take_snapshot(page, user=page.owner)
+    project_timeline = service.get_project_timeline(page.project)
+    assert project_timeline[0].event_type == "wiki.wikipage.change"
+    assert project_timeline[0].data["wiki_page"]["slug"] == "test wiki page timeline updated"
+    assert project_timeline[0].data["values_diff"]["slug"][0] == "test wiki page timeline"
+    assert project_timeline[0].data["values_diff"]["slug"][1] == "test wiki page timeline updated"
+
+
+def test_update_membership_timeline():
+    user_1 = factories.UserFactory.create()
+    user_2 = factories.UserFactory.create()
+    membership = factories.MembershipFactory.create(user=user_1)
+    membership.user = user_2
+    membership.save()
+    project_timeline = service.get_project_timeline(membership.project)
+    user_1_timeline = service.get_user_timeline(user_1)
+    user_2_timeline = service.get_user_timeline(user_2)
+    assert project_timeline[0].event_type == "projects.membership.delete"
+    assert project_timeline[0].data["project"]["id"] == membership.project.id
+    assert project_timeline[0].data["user"]["id"] == user_1.id
+    assert project_timeline[0].data["user"]["name"] == user_1.get_full_name()
+    assert project_timeline[1].event_type == "projects.membership.create"
+    assert project_timeline[1].data["project"]["id"] == membership.project.id
+    assert project_timeline[1].data["user"]["id"] == user_2.id
+    assert project_timeline[1].data["user"]["name"] == user_2.get_full_name()
+    assert user_1_timeline[0].event_type == "projects.membership.delete"
+    assert user_1_timeline[0].data["project"]["id"] == membership.project.id
+    assert user_1_timeline[0].data["user"]["id"] == user_1.id
+    assert user_1_timeline[0].data["user"]["name"] == user_1.get_full_name()
+    assert user_2_timeline[0].event_type == "projects.membership.create"
+    assert user_2_timeline[0].data["project"]["id"] == membership.project.id
+    assert user_2_timeline[0].data["user"]["id"] == user_2.id
+    assert user_2_timeline[0].data["user"]["name"] == user_2.get_full_name()
+
+
+def test_delete_project_timeline():
+    project = factories.ProjectFactory.create(name="test project timeline")
+    history_services.take_snapshot(project, user=project.owner, delete=True)
+    user_timeline = service.get_project_timeline(project)
+    assert user_timeline[0].event_type == "projects.project.delete"
+    assert user_timeline[0].data["project"]["id"] == project.id
+
+
+def test_delete_milestone_timeline():
+    milestone = factories.MilestoneFactory.create(name="test milestone timeline")
+    history_services.take_snapshot(milestone, user=milestone.owner, delete=True)
+    project_timeline = service.get_project_timeline(milestone.project)
+    assert project_timeline[0].event_type == "milestones.milestone.delete"
+    assert project_timeline[0].data["milestone"]["name"] == "test milestone timeline"
+
+
+def test_delete_user_story_timeline():
+    user_story = factories.UserStoryFactory.create(subject="test us timeline")
+    history_services.take_snapshot(user_story, user=user_story.owner, delete=True)
+    project_timeline = service.get_project_timeline(user_story.project)
+    assert project_timeline[0].event_type == "userstories.userstory.delete"
+    assert project_timeline[0].data["userstory"]["subject"] == "test us timeline"
+
+
+def test_delete_issue_timeline():
+    issue = factories.IssueFactory.create(subject="test issue timeline")
+    history_services.take_snapshot(issue, user=issue.owner, delete=True)
+    project_timeline = service.get_project_timeline(issue.project)
+    assert project_timeline[0].event_type == "issues.issue.delete"
+    assert project_timeline[0].data["issue"]["subject"] == "test issue timeline"
+
+
+def test_delete_task_timeline():
+    task = factories.TaskFactory.create(subject="test task timeline")
+    history_services.take_snapshot(task, user=task.owner, delete=True)
+    project_timeline = service.get_project_timeline(task.project)
+    assert project_timeline[0].event_type == "tasks.task.delete"
+    assert project_timeline[0].data["task"]["subject"] == "test task timeline"
+
+
+def test_delete_wiki_page_timeline():
+    page = factories.WikiPageFactory.create(slug="test wiki page timeline")
+    history_services.take_snapshot(page, user=page.owner, delete=True)
+    project_timeline = service.get_project_timeline(page.project)
+    assert project_timeline[0].event_type == "wiki.wikipage.delete"
+    assert project_timeline[0].data["wiki_page"]["slug"] == "test wiki page timeline"
+
+
+def test_delete_membership_timeline():
+    membership = factories.MembershipFactory.create()
+    membership.delete()
+    project_timeline = service.get_project_timeline(membership.project)
+    user_timeline = service.get_user_timeline(membership.user)
+    assert project_timeline[0].event_type == "projects.membership.delete"
+    assert project_timeline[0].data["project"]["id"] == membership.project.id
+    assert project_timeline[0].data["user"]["id"] == membership.user.id
+    assert project_timeline[0].data["user"]["name"] == membership.user.get_full_name()
+    assert user_timeline[0].event_type == "projects.membership.delete"
+    assert user_timeline[0].data["project"]["id"] == membership.project.id
+    assert user_timeline[0].data["user"]["id"] == membership.user.id
+    assert user_timeline[0].data["user"]["name"] == membership.user.get_full_name()
+
+
+def test_comment_user_story_timeline():
+    user_story = factories.UserStoryFactory.create(subject="test us timeline")
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    history_services.take_snapshot(user_story, user=user_story.owner, comment="testing comment")
+    project_timeline = service.get_project_timeline(user_story.project)
+    assert project_timeline[0].event_type == "userstories.userstory.change"
+    assert project_timeline[0].data["userstory"]["subject"] == "test us timeline"
+    assert project_timeline[0].data["comment"] == "testing comment"
+
+
+def test_owner_user_story_timeline():
+    user_story = factories.UserStoryFactory.create(subject="test us timeline")
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    user_timeline = service.get_user_timeline(user_story.owner)
+    assert user_timeline[0].event_type == "userstories.userstory.create"
+    assert user_timeline[0].data["userstory"]["subject"] == "test us timeline"
+
+
+def test_assigned_to_user_story_timeline():
+    membership = factories.MembershipFactory.create()
+    user_story = factories.UserStoryFactory.create(subject="test us timeline", assigned_to=membership.user)
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    user_timeline = service.get_profile_timeline(user_story.assigned_to)
+    assert user_timeline[0].event_type == "userstories.userstory.create"
+    assert user_timeline[0].data["userstory"]["subject"] == "test us timeline"
+
+
+def test_watchers_to_user_story_timeline():
+    membership = factories.MembershipFactory.create()
+    user_story = factories.UserStoryFactory.create(subject="test us timeline")
+    user_story.watchers.add(membership.user)
+    history_services.take_snapshot(user_story, user=user_story.owner)
+    user_timeline = service.get_profile_timeline(membership.user)
+    assert user_timeline[0].event_type == "userstories.userstory.create"
+    assert user_timeline[0].data["userstory"]["subject"] == "test us timeline"

tests/unit/test_timeline.py

@@ -76,12 +76,6 @@ def test_get_impl_key_from_typename():
         service._get_impl_key(None)
 
 
-def test_get_class_implementation():
-    service._timeline_impl_map["timeline.timeline.test"] = "test"
-    assert service._get_class_implementation(Timeline, "test") == "test"
-    assert service._get_class_implementation(Timeline, "other") is None
-
-
 def test_register_timeline_implementation():
     test_func = lambda x: "test-func-result"
     service.register_timeline_implementation("timeline.timeline", "test", test_func)