taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Moved list_of_milestones method from the model to the serializer

remotes/origin/enhancement/email-actions
David Barragán Merino 2013-10-17 15:38:07 +02:00
parent 3df7eea9e9
commit 6b5aad4bef
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
greenmine/projects/models.py
View File

@ -110,16 +110,6 @@ class Project(models.Model):
super(Project, self).save(*args, **kwargs)
@property
def list_of_milestones(self):
return [{
"id": milestone.id,
"name": milestone.name,
"finish_date": milestone.estimated_finish,
"closed_points": milestone.closed_points,
"client_increment_points": milestone.client_increment_points,
"team_increment_points": milestone.team_increment_points
} for milestone in self.milestones.all().order_by("estimated_start")]
def get_roles(self):
role_model = get_model("users", "Role")

17
greenmine/projects/serializers.py
View File

@ -71,7 +71,7 @@ class QuestionStatusSerializer(serializers.ModelSerializer):
class ProjectSerializer(serializers.ModelSerializer):
tags = PickleField(required=False)
list_of_milestones = serializers.Field(source="list_of_milestones")
list_of_milestones = serializers.SerializerMethodField("get_list_of_milestones")
us_statuses = UserStoryStatusSerializer(many=True, required=False) # User Stories
points = PointsSerializer(many=True, required=False)
task_statuses = TaskStatusSerializer(many=True, required=False) # Tasks
@ -84,3 +84,18 @@ class ProjectSerializer(serializers.ModelSerializer):
class Meta:
model = models.Project
read_only_fields = ("owner",)
def get_list_of_milestones(self, obj):
milestones_list = []
if obj and obj.memberships:
milestones_list = [{
"id": milestone.id,
"name": milestone.name,
"finish_date": milestone.estimated_finish,
"closed_points": milestone.closed_points,
"client_increment_points": milestone.client_increment_points,
"team_increment_points": milestone.team_increment_points
} for milestone in obj.milestones.all().order_by("estimated_start")]
return milestones_list