taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Migrating feedback serializers

remotes/origin/issue/4795/notification_even_they_are_disabled
Jesús Espino 2016-07-05 23:48:33 +02:00 committed by David Barragán Merino
parent 04102e3b9f
commit 8d86c42fa0
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
taiga/feedback/api.py
View File

@ -20,7 +20,7 @@ from taiga.base import response
from taiga.base.api import viewsets from taiga.base.api import viewsets
from . import permissions from . import permissions
from . import serializers from . import validators
from . import services from . import services
import copy import copy
@ -28,7 +28,7 @@ import copy
class FeedbackViewSet(viewsets.ViewSet): class FeedbackViewSet(viewsets.ViewSet):
permission_classes = (permissions.FeedbackPermission,) permission_classes = (permissions.FeedbackPermission,)
serializer_class = serializers.FeedbackEntrySerializer validator_class = validators.FeedbackEntryValidator
def create(self, request, **kwargs): def create(self, request, **kwargs):
self.check_permissions(request, "create", None) self.check_permissions(request, "create", None)
@ -37,11 +37,11 @@ class FeedbackViewSet(viewsets.ViewSet):
data.update({"full_name": request.user.get_full_name(), data.update({"full_name": request.user.get_full_name(),
"email": request.user.email}) "email": request.user.email})
serializer = self.serializer_class(data=data) validator = self.validator_class(data=data)
if not serializer.is_valid(): if not validator.is_valid():
return response.BadRequest(serializer.errors) return response.BadRequest(validator.errors)
self.object = serializer.save(force_insert=True) self.object = validator.save(force_insert=True)
extra = { extra = {
"HTTP_HOST": request.META.get("HTTP_HOST", None), "HTTP_HOST": request.META.get("HTTP_HOST", None),
@ -50,4 +50,4 @@ class FeedbackViewSet(viewsets.ViewSet):
} }
services.send_feedback(self.object, extra, reply_to=[request.user.email]) services.send_feedback(self.object, extra, reply_to=[request.user.email])
return response.Ok(serializer.data) return response.Ok(validator.data)

4
taiga/feedback/serializers.py → taiga/feedback/validators.py
View File

@ -16,11 +16,11 @@
# You should have received a copy of the GNU Affero General Public License # You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
from taiga.base.api import serializers from taiga.base.api import validators
from . import models from . import models
class FeedbackEntrySerializer(serializers.ModelSerializer): class FeedbackEntryValidator(validators.ModelValidator):
class Meta: class Meta:
model = models.FeedbackEntry model = models.FeedbackEntry