From 9cd86a369907feb9b34f86bc8ef0c87da14974dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?= Date: Wed, 26 Oct 2016 10:07:12 +0200 Subject: [PATCH] Fix some flake8 errors --- taiga/base/signals/cleanup_files.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/taiga/base/signals/cleanup_files.py b/taiga/base/signals/cleanup_files.py index e2449ce2..4489b599 100644 --- a/taiga/base/signals/cleanup_files.py +++ b/taiga/base/signals/cleanup_files.py @@ -18,20 +18,18 @@ from django.apps import apps from django.db import models, connection -from django.db.utils import DEFAULT_DB_ALIAS, ConnectionHandler from django.db.models.signals import pre_save, post_delete +from django.dispatch import Signal import logging + logger = logging.getLogger(__name__) -from django.dispatch import Signal - cleanup_pre_delete = Signal(providing_args=["file"]) cleanup_post_delete = Signal(providing_args=["file"]) - def _find_models_with_filefield(): result = [] for model in apps.get_models(): @@ -50,7 +48,7 @@ def _delete_file(file_obj): cleanup_post_delete.send(sender=None, file=file_obj) except Exception: logger.exception("Unexpected exception while attempting " - "to delete old file '%s'".format(file_obj.name)) + "to delete old file '%s'".format(file_obj.name)) storage = file_obj.storage if storage and storage.exists(file_obj.name): @@ -90,9 +88,6 @@ def remove_files_on_delete(sender, instance, **kwargs): def connect_cleanup_files_signals(): - connections = ConnectionHandler() - backend = connections[DEFAULT_DB_ALIAS] - for model in _find_models_with_filefield(): pre_save.connect(remove_files_on_change, sender=model) post_delete.connect(remove_files_on_delete, sender=model)