From ad169764341bf3aa2a390151455e80e714bb9aef Mon Sep 17 00:00:00 2001
From: Andrey Antukh <niwi@niwi.be>
Date: Fri, 3 Oct 2014 20:11:44 +0200
Subject: [PATCH] Rename and improve test names on us autoclossing tests
 module.

---
 ...st_close_uss.py => test_us_autoclosing.py} | 62 +++++++++++--------
 1 file changed, 37 insertions(+), 25 deletions(-)
 rename tests/integration/{test_close_uss.py => test_us_autoclosing.py} (89%)

diff --git a/tests/integration/test_close_uss.py b/tests/integration/test_us_autoclosing.py
similarity index 89%
rename from tests/integration/test_close_uss.py
rename to tests/integration/test_us_autoclosing.py
index 992f30de..35620026 100644
--- a/tests/integration/test_close_uss.py
+++ b/tests/integration/test_us_autoclosing.py
@@ -40,7 +40,7 @@ def data():
     return m
 
 
-def test_us_without_tasks_open_close_us_status(data):
+def test_auto_close_us_when_change_us_status_to_closed_without_tasks(data):
     assert data.user_story2.is_closed is False
     data.user_story2.status = data.us_closed_status
     data.user_story2.save()
@@ -52,7 +52,7 @@ def test_us_without_tasks_open_close_us_status(data):
     assert data.user_story2.is_closed is False
 
 
-def test_us_with_tasks_open_close_us_status(data):
+def test_noop_when_change_us_status_to_closed_with_open_tasks(data):
     assert data.user_story1.is_closed is False
     data.user_story1.status = data.us_closed_status
     data.user_story1.save()
@@ -64,101 +64,100 @@ def test_us_with_tasks_open_close_us_status(data):
     assert data.user_story1.is_closed is False
 
 
-def test_us_on_task_delete_empty_close(data):
+def test_auto_close_us_with_closed_state_when_all_tasks_are_deleted(data):
     data.user_story1.status = data.us_closed_status
     data.user_story1.save()
+
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task3.delete()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task2.delete()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task1.delete()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
 
 
-def test_us_on_task_delete_empty_open(data):
+def test_auto_open_us_with_open_status_when_all_tasks_are_deleted(data):
     data.task1.status = data.task_closed_status
     data.task1.save()
     data.task2.status = data.task_closed_status
     data.task2.save()
     data.task3.status = data.task_closed_status
     data.task3.save()
+
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task3.delete()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task2.delete()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task1.delete()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
 
 
-def test_us_with_tasks_on_move_empty_open(data):
+def test_auto_open_us_with_open_status_when_all_task_are_moved_to_another_us(data):
     data.task1.status = data.task_closed_status
     data.task1.save()
     data.task2.status = data.task_closed_status
     data.task2.save()
     data.task3.status = data.task_closed_status
     data.task3.save()
+
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task3.user_story = data.user_story2
     data.task3.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task2.user_story = data.user_story2
     data.task2.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task1.user_story = data.user_story2
     data.task1.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
 
 
-def test_us_with_tasks_on_move_empty_close(data):
+def test_auto_close_us_closed_status_when_all_tasks_are_moved_to_another_us(data):
     data.user_story1.status = data.us_closed_status
     data.user_story1.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task3.user_story = data.user_story2
     data.task3.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task2.user_story = data.user_story2
     data.task2.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task1.user_story = data.user_story2
     data.task1.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
 
 
-def test_us_close_last_tasks(data):
-    assert data.user_story1.is_closed is False
-    data.task3.status = data.task_closed_status
-    data.task3.save()
-    data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
-    assert data.user_story1.is_closed is False
-    data.task2.status = data.task_closed_status
-    data.task2.save()
-    data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
-    assert data.user_story1.is_closed is False
-    data.task1.status = data.task_closed_status
-    data.task1.save()
-    data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
-    assert data.user_story1.is_closed is True
-
-
-def test_us_reopen_tasks(data):
+def test_auto_close_us_when_tasks_are_gradually_reopened(data):
     data.task1.status = data.task_closed_status
     data.task1.save()
     data.task2.status = data.task_closed_status
@@ -167,21 +166,28 @@ def test_us_reopen_tasks(data):
     data.task3.save()
 
     assert data.user_story1.is_closed is True
+
     data.task3.status = data.task_open_status
     data.task3.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task2.status = data.task_open_status
     data.task2.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
+
     data.task1.status = data.task_open_status
     data.task1.save()
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
 
 
-def test_us_delete_task_then_all_closed(data):
+def test_auto_close_us_after_open_task_is_deleted(data):
+    """
+    User story should be in closed state after
+    delete the unique open task.
+    """
     data.task1.status = data.task_closed_status
     data.task1.save()
     data.task2.status = data.task_closed_status
@@ -230,17 +236,20 @@ def test_auto_close_us_when_all_tasks_are_changed_to_close_status(data):
     assert data.user_story1.is_closed is True
 
 
-def test_us_change_task_us_then_any_open(data):
+def test_auto_open_us_when_add_open_task(data):
     data.task1.status = data.task_closed_status
     data.task1.save()
     data.task2.status = data.task_closed_status
     data.task2.save()
     data.task3.user_story = data.user_story2
     data.task3.save()
+
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     data.task3.user_story = data.user_story1
     data.task3.save()
+
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False
 
@@ -252,11 +261,14 @@ def test_task_create(data):
     data.task2.save()
     data.task3.status = data.task_closed_status
     data.task3.save()
+
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     f.TaskFactory(user_story=data.user_story1, status=data.task_closed_status)
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is True
+
     f.TaskFactory(user_story=data.user_story1, status=data.task_open_status)
     data.user_story1 = UserStory.objects.get(pk=data.user_story1.pk)
     assert data.user_story1.is_closed is False