taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #671 from taigaio/fix/project_owners_cannot_be_no_admin 

Project owners can not be no admin
remotes/origin/issue/4795/notification_even_they_are_disabled
Alejandro 2016-03-18 12:06:58 +01:00
parent f675cea441 af588be527
commit b1b339630b
2 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
taiga/projects/serializers.py
View File

@ -190,9 +190,13 @@ class MembershipSerializer(serializers.ModelSerializer):
if project is None:
project = self.object.project
if (self.object and
not services.project_has_valid_admins(project, exclude_user=self.object.user)):
raise serializers.ValidationError(_("In this project at least one of the users must be an active admin."))
if (self.object):
if self.object.user.id == project.owner_id and attrs[source] != True:
raise serializers.ValidationError(_("Project owner must be admin."))
if not services.project_has_valid_admins(project, exclude_user=self.object.user):
raise serializers.ValidationError(_("In this project at least one of the users "
"must be an active admin."))
return attrs

14
tests/integration/test_memberships.py
View File

@ -347,6 +347,20 @@ def test_api_edit_membership(client):
assert response.status_code == 200
def test_api_change_owner_membership_to_no_admin_return_error(client):
project = f.ProjectFactory()
membership_owner = f.MembershipFactory(project=project, user=project.owner, is_admin=True)
membership = f.MembershipFactory(project=project, is_admin=True)
url = reverse("memberships-detail", args=[membership_owner.id])
data = {"is_admin": False}
client.login(membership.user)
response = client.json.patch(url, json.dumps(data))
assert response.status_code == 400
assert 'is_admin' in response.data
def test_api_delete_membership(client):
membership = f.MembershipFactory(is_admin=True)