taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

moving total_memberships to project detail serializer

remotes/origin/issue/4795/notification_even_they_are_disabled
Alejandro Alonso 2016-03-30 12:29:12 +02:00
parent 7c505b70d9
commit fab3c1f199
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
taiga/projects/serializers.py
View File

@ -344,6 +344,7 @@ class ProjectDetailSerializer(ProjectSerializer):
roles = ProjectRoleSerializer(source="roles", many=True, read_only=True) roles = ProjectRoleSerializer(source="roles", many=True, read_only=True)
members = serializers.SerializerMethodField(method_name="get_members") members = serializers.SerializerMethodField(method_name="get_members")
total_memberships = serializers.SerializerMethodField(method_name="get_total_memberships")
def get_members(self, obj): def get_members(self, obj):
qs = obj.memberships.filter(user__isnull=False) qs = obj.memberships.filter(user__isnull=False)
@ -353,11 +354,13 @@ class ProjectDetailSerializer(ProjectSerializer):
serializer = ProjectMemberSerializer(qs, many=True) serializer = ProjectMemberSerializer(qs, many=True)
return serializer.data return serializer.data
def get_total_memberships(self, obj):
return services.get_total_project_memberships(obj)
class ProjectDetailAdminSerializer(ProjectDetailSerializer): class ProjectDetailAdminSerializer(ProjectDetailSerializer):
is_private_extra_info = serializers.SerializerMethodField(method_name="get_is_private_extra_info") is_private_extra_info = serializers.SerializerMethodField(method_name="get_is_private_extra_info")
max_memberships = serializers.SerializerMethodField(method_name="get_max_memberships") max_memberships = serializers.SerializerMethodField(method_name="get_max_memberships")
total_memberships = serializers.SerializerMethodField(method_name="get_total_memberships")
class Meta: class Meta:
model = models.Project model = models.Project
@ -370,8 +373,6 @@ class ProjectDetailAdminSerializer(ProjectDetailSerializer):
def get_max_memberships(self, obj): def get_max_memberships(self, obj):
return services.get_max_memberships_for_project(obj) return services.get_max_memberships_for_project(obj)
def get_total_memberships(self, obj):
return services.get_total_project_memberships(obj)