taiga
/
taiga-front
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[backport] fix xss issues in timeline & lightbox confirmation

stable
Juanfran 2015-11-10 14:20:52 +01:00
parent 502a542191
commit 569023e0f5
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/coffee/modules/common/confirm.coffee
View File

@ -56,9 +56,9 @@ class ConfirmService extends taiga.Service
el = angular.element(lightboxSelector)
# Render content
el.find("h2.title").html(title)
el.find("span.subtitle").html(subtitle)
el.find("span.message").html(message)
el.find("h2.title").text(title)
el.find("span.subtitle").text(subtitle)
el.find("span.message").text(message)
# Assign event handlers
el.on "click.confirm-dialog", "a.button-green", debounce 2000, (event) =>

8
app/modules/user-timeline/user-timeline-item/user-timeline-item-title.service.coffee
View File

@ -67,9 +67,11 @@ class UserTimelineItemTitle
if value == null && timeline.getIn(["data", "value_diff", "key"]) == 'assigned_to'
value = @translate.instant('ACTIVITY.VALUES.UNASSIGNED')
return value
new_value = value
else
return timeline.getIn(["data", "value_diff", "value"]).first().get(1)
new_value = timeline.getIn(["data", "value_diff", "value"]).first().get(1)
return _.escape(new_value)
sprint_name: (timeline, event) ->
url = "project-taskboard:project=timeline.getIn(['data', 'project', 'slug']),sprint=timeline.getIn(['data', 'milestone', 'slug'])"
@ -100,7 +102,7 @@ class UserTimelineItemTitle
return @._getLink(url, text)
role_name: (timeline, event) ->
return timeline.getIn(['data', 'value_diff', 'value']).keySeq().first()
return _.escape(timeline.getIn(['data', 'value_diff', 'value']).keySeq().first())
}
constructor: (@translate) ->