Merge pull request #1054 from taigaio/bug/4345/disable-drag-and-drop-on-wiki-links-without-permissions

Bug#4345: Disable drag and drop on wikilink without permissions

app/coffee/modules/wiki/nav.coffee

@@ -45,31 +45,35 @@ WikiNavDirective = ($tgrepo, $log, $location, $confirm, $analytics, $loading, $t
         itemEl = null
         tdom = $el.find(".sortable")
 
-        drake = dragula([tdom[0]], {
+        addWikiLinkPermission = $scope.project.my_permissions.indexOf("add_wiki_link") > -1
-            direction: 'vertical',
-            copySortSource: false,
-            copy: false,
-            mirrorContainer: tdom[0],
-            moves: (item) -> return $(item).is('li')
-        })
 
-        drake.on 'dragend', (item) ->
+        if addWikiLinkPermission
-            itemEl = $(item)
+            drake = dragula([tdom[0]], {
-            item = itemEl.scope().link
+                direction: 'vertical',
-            itemIndex = itemEl.index()
+                copySortSource: false,
-            $scope.$emit("wiki:links:move", item, itemIndex)
+                copy: false,
+                mirrorContainer: tdom[0],
+                moves: (item) -> return $(item).is('li')
+            })
 
-        scroll = autoScroll(window, {
+            drake.on 'dragend', (item) ->
-            margin: 20,
+                itemEl = $(item)
-            pixels: 30,
+                item = itemEl.scope().link
-            scrollWhenOutside: true,
+                itemIndex = itemEl.index()
-            autoScroll: () ->
+                $scope.$emit("wiki:links:move", item, itemIndex)
-                return this.down && drake.dragging;
+
-        })
+            scroll = autoScroll(window, {
+                margin: 20,
+                pixels: 30,
+                scrollWhenOutside: true,
+                autoScroll: () ->
+                    return this.down && drake.dragging;
+            })
 
         $scope.$on "$destroy", ->
             $el.off()
-            drake.destroy()
+            if addWikiLinkPermission
+                drake.destroy()
 
     linkWikiLinks = ($scope, $el, $attrs) ->
         $ctrl = $el.controller()

app/partials/wiki/wiki-nav.jade

@@ -18,7 +18,12 @@ nav
             )
 
     ul.sortable
-        li.wiki-link(ng-repeat="link in wikiLinks", data-id!="{{ $index }}", tg-bind-scope)
+        li.wiki-link(
+            ng-repeat="link in wikiLinks"
+            data-id!="{{ $index }}"
+            tg-bind-scope
+            tg-class-permission="{'is-sortable': 'add_wiki_link'}"
+        )
             <% if (addWikiLinkPermission) { %>
             tg-svg.dragger(svg-icon="icon-drag")
             <% } %>

app/styles/modules/wiki/wiki-nav.scss

@@ -2,7 +2,6 @@
     @include font-type(text);
     align-items: center;
     border-bottom: 1px solid $gray-light;
-    cursor: move;
     display: flex;
     justify-content: space-between;
     padding: 1rem 0;
@@ -22,6 +21,9 @@
             transition-delay: .2s;
         }
     }
+    &.is-sortable {
+        cursor: move;
+    }
     .dragger {
         margin-right: .5rem;
         opacity: 0;