From 572989b83683f238f5c442f85a4452c2c578775d Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Tue, 5 May 2015 07:34:46 +0200 Subject: [PATCH] Fixing reordering issue when filters enabled, error message was shown but order was updated anyway --- app/coffee/modules/backlog/sortable.coffee | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/coffee/modules/backlog/sortable.coffee b/app/coffee/modules/backlog/sortable.coffee index 6484c044..48d9eea2 100644 --- a/app/coffee/modules/backlog/sortable.coffee +++ b/app/coffee/modules/backlog/sortable.coffee @@ -55,7 +55,7 @@ BacklogSortableDirective = ($repo, $rs, $rootscope, $tgConfirm, $translate) -> filterError = -> text = $translate.instant("BACKLOG.SORTABLE_FILTER_ERROR") - $tgConfirm.notify(text) + $tgConfirm.notify("error", text) $el.sortable({ items: ".us-item-row", @@ -100,6 +100,9 @@ BacklogSortableDirective = ($repo, $rs, $rootscope, $tgConfirm, $translate) -> if $(ui.items[0]).parent().length == 0 return + if $el.hasClass("active-filters") + return + items = _.sortBy ui.items, (item) -> return $(item).index()